Stop publishing to the internal container registry #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
approved these changes
Feb 12, 2024
Currently the base images are published not only to Docker Hub, but also an internal container registry. However, the last remaining consumer of the base-images from the internal registry is migrating away from these images as of: heroku/kodon#483 As such, there is no longer any need to publish to this registry, which simplifies the publishing process here, and means one less set of credentials to manage/rotate. GUS-W-15019312.
edmorley
force-pushed
the
edmorley/rm-internal-registry
branch
from
9cdb576 to
a0b50fc
Compare
|
I've deleted all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the base images are published not only to Docker Hub, but also an internal container registry.
However, the last remaining consumer of the base-images from the internal registry is migrating away from these images as of:
https://github.com/heroku/kodon/pull/483
As such, there is no longer any need to publish to this registry, which simplifies the publishing process here, and means one less set of credentials to manage/rotate.
GUS-W-15019312.