Skip to content

Commit

Permalink
Switch some additional usages
Browse files Browse the repository at this point in the history
  • Loading branch information
edmorley committed Jan 18, 2024
1 parent ea752fd commit 807d67a
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion BUILD.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ We use GitHub Actions to build and release Heroku Base Images:

# Releasing Heroku Base Images Locally (Prime)

When building Heroku Base Images for release locally, youll need a number of additional steps.
When building Heroku Base Images for release locally, you'll need a number of additional steps.

NOTE: These steps do *not* apply to `*cnb*` images.

Expand Down
10 changes: 5 additions & 5 deletions bin/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@ write_package_list() {
RUN_IMAGE_TAG="heroku/heroku:${STACK_VERSION}"
RUN_DOCKERFILE_DIR="heroku-${STACK_VERSION}"
[[ -d "${RUN_DOCKERFILE_DIR}" ]] || abort "fatal: directory ${RUN_DOCKERFILE_DIR} not found"
display "Building ${RUN_DOCKERFILE_DIR} / ${RUN_IMAGE_TAG} Heroku runtime image"
display "Building ${RUN_DOCKERFILE_DIR} / ${RUN_IMAGE_TAG} Heroku run image"
docker build --pull --tag "${RUN_IMAGE_TAG}" "${RUN_DOCKERFILE_DIR}" | indent
write_package_list "${RUN_IMAGE_TAG}" "${RUN_DOCKERFILE_DIR}"

# The --pull option is not used for variants to ensure they are based on the
# runtime stack image built above, rather than the one last published to DockerHub.
# run image built above, rather than the one last published to Docker Hub.

BUILD_IMAGE_TAG="${RUN_IMAGE_TAG}-build"
BUILD_DOCKERFILE_DIR="${RUN_DOCKERFILE_DIR}-build"
display "Building ${BUILD_DOCKERFILE_DIR} / ${BUILD_IMAGE_TAG} Heroku build-time image"
display "Building ${BUILD_DOCKERFILE_DIR} / ${BUILD_IMAGE_TAG} Heroku build image"
docker build --tag "$BUILD_IMAGE_TAG" "$BUILD_DOCKERFILE_DIR" | indent
write_package_list "$BUILD_IMAGE_TAG" "$BUILD_DOCKERFILE_DIR"

Expand All @@ -37,12 +37,12 @@ write_package_list "$BUILD_IMAGE_TAG" "$BUILD_DOCKERFILE_DIR"

CNB_RUN_IMAGE_TAG="${RUN_IMAGE_TAG}-cnb"
CNB_RUN_DOCKERFILE_DIR="${RUN_DOCKERFILE_DIR}-cnb"
display "Building ${CNB_RUN_DOCKERFILE_DIR} / ${CNB_RUN_IMAGE_TAG} CNB runtime image"
display "Building ${CNB_RUN_DOCKERFILE_DIR} / ${CNB_RUN_IMAGE_TAG} CNB run image"
docker build --tag "$CNB_RUN_IMAGE_TAG" "$CNB_RUN_DOCKERFILE_DIR" | indent

CNB_BUILD_IMAGE_TAG="${RUN_IMAGE_TAG}-cnb-build"
CNB_BUILD_DOCKERFILE_DIR="${RUN_DOCKERFILE_DIR}-cnb-build"
display "Building ${CNB_BUILD_DOCKERFILE_DIR} / ${CNB_BUILD_IMAGE_TAG} CNB build-time image"
display "Building ${CNB_BUILD_DOCKERFILE_DIR} / ${CNB_BUILD_IMAGE_TAG} CNB build image"
docker build --tag "$CNB_BUILD_IMAGE_TAG" "$CNB_BUILD_DOCKERFILE_DIR" | indent

display "Size breakdown..."
Expand Down
2 changes: 1 addition & 1 deletion heroku-20/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ IMAGEMAGICK_POLICY
# Temporarily install ca-certificates-java to generate the certificates store used
# by Java apps. Generation occurs in a post-install script which requires a JRE.
# We're using OpenJDK 8 rather than something newer, to work around:
# https://github.com/heroku/stack-images/pull/103#issuecomment-389544431
# https://github.com/heroku/base-images/pull/103#issuecomment-389544431
apt-get install -y --no-install-recommends ca-certificates-java openjdk-8-jre-headless
# Using remove rather than purge so that the generated certs are left behind.
apt-get remove -y ca-certificates-java
Expand Down
2 changes: 1 addition & 1 deletion heroku-22/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ IMAGEMAGICK_POLICY
# Temporarily install ca-certificates-java to generate the certificates store used
# by Java apps. Generation occurs in a post-install script which requires a JRE.
# We're using OpenJDK 8 rather than something newer, to work around:
# https://github.com/heroku/stack-images/pull/103#issuecomment-389544431
# https://github.com/heroku/base-images/pull/103#issuecomment-389544431
apt-get install -y --no-install-recommends ca-certificates-java openjdk-8-jre-headless
# Using remove rather than purge so that the generated certs are left behind.
apt-get remove -y ca-certificates-java
Expand Down
2 changes: 1 addition & 1 deletion tools/bin/publish-manifests
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ if ls /tmp/*64-*.manifest >& /dev/null; then
}) | {stacks: .}' \
/tmp/*64-*.manifest |
curl \
--fail --user-agent 'Stack Image Tools' \
--fail --user-agent 'Base Image Tools' \
--header "Authorization: Bearer $MANIFEST_APP_TOKEN" \
--header "Content-Type: application/json" \
--request PATCH \
Expand Down
4 changes: 2 additions & 2 deletions tools/bin/upload-image
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jq \
}' |
curl \
--silent --show-error --fail \
--user-agent 'Stack Image Tools' \
--user-agent 'Base Image Tools' \
--header "Authorization: Bearer $MANIFEST_APP_TOKEN" \
--header "Content-Type: application/json" \
--data @- \
Expand All @@ -43,7 +43,7 @@ display "Uploading Image to S3"
PUT_URL=$(jq -r .put_url "$IMG_MANIFEST")
curl \
--silent --show-error \
--user-agent 'Stack Image Tools' \
--user-agent 'Base Image Tools' \
--header "Content-Type: application/octet-stream" \
--upload-file "$IMG_GZ" \
"$PUT_URL"

0 comments on commit 807d67a

Please sign in to comment.