Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked uhyve output #796

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Reworked uhyve output #796

merged 6 commits into from
Nov 20, 2024

Conversation

jounathaen
Copy link
Member

@jounathaen jounathaen commented Nov 20, 2024

@n0toose
Copy link
Member

n0toose commented Nov 20, 2024

Note: Freeing up -v means that we'll be able to use this parameter for #796.

@jounathaen jounathaen force-pushed the verbose branch 2 times, most recently from 0780c42 to 20ae28c Compare November 20, 2024 18:59
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 72.03390% with 33 lines in your changes missing coverage. Please review.

Project coverage is 66.82%. Comparing base (b322724) to head (6111373).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/vm.rs 65.90% 15 Missing ⚠️
src/hypercall.rs 78.12% 7 Missing ⚠️
src/bin/uhyve.rs 0.00% 5 Missing ⚠️
src/params.rs 44.44% 5 Missing ⚠️
src/linux/mod.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
- Coverage   66.83%   66.82%   -0.02%     
==========================================
  Files          19       19              
  Lines        2503     2568      +65     
==========================================
+ Hits         1673     1716      +43     
- Misses        830      852      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jounathaen jounathaen marked this pull request as ready for review November 20, 2024 19:32
@jounathaen jounathaen added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit a7eba1c Nov 20, 2024
10 checks passed
@jounathaen jounathaen deleted the verbose branch November 20, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch output from kernel Uhyve doesn't halt when not run with -v
2 participants