Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-188: example for discrete spectra #190

Merged
merged 4 commits into from
Sep 10, 2024
Merged

gh-188: example for discrete spectra #190

merged 4 commits into from
Sep 10, 2024

Conversation

ntessore
Copy link
Contributor

@ntessore ntessore commented Sep 6, 2024

Adds a notebook that demonstrates how to compute discrete angular power spectra with Heracles.

Closes: #188

@ntessore ntessore requested a review from a team September 6, 2024 11:08
ucapbba
ucapbba reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@ucapbba ucapbba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encapsulation of get_example_data makes both examples easier to read, and also only runs download if files not already present, as expected. discrete.ipynb runs without issue

@ntessore ntessore merged commit bfed439 into main Sep 10, 2024
8 checks passed
@ntessore ntessore deleted the nt-188 branch September 10, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ucapbba ucapbba ucapbba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add example for discrete spectra
2 participants
@ntessore @ucapbba