SmrPlayer: remove references from setPlottedCourse

The argument to this function should not be passed by reference. See smrealms#317.
hemberger · May 16, 2018 · 02f426f · 02f426f
1 parent 2218c0e
commit 02f426f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/Default/SmrPlayer.class.inc b/lib/Default/SmrPlayer.class.inc
@@ -1888,9 +1888,9 @@ class SmrPlayer extends AbstractSmrPlayer {
 		return $this->plottedCourse;
 	}
 
-	public function setPlottedCourse(Distance &$plottedCourse) {
+	public function setPlottedCourse(Distance $plottedCourse) {
 		$hadPlottedCourse = $this->hasPlottedCourse();
-		$this->plottedCourse =& $plottedCourse;
+		$this->plottedCourse = $plottedCourse;
 		if ($this->plottedCourse->getTotalSectors()>0)
 			$this->db->query('REPLACE INTO player_plotted_course
 				(account_id, game_id, course)