feat(providers): Add support for 1Password using service account tokens #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoispag
requested review from
mumoshu,
itscaro,
yxxhero and
xiaomudk
as code owners
zoispag
changed the title
Signed-off-by: Zois Pagoulatos <[email protected]>
|
@yxxhero I don’t understand the linter error. Can you provide some guidance please? |
yxxhero
reviewed
May 18, 2024
|
@zoispag please fix DCO issue. |
Signed-off-by: Zois Pagoulatos <[email protected]>
yxxhero
reviewed
May 18, 2024
yxxhero
approved these changes
May 19, 2024
yxxhero
approved these changes
May 19, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last July, 1Password announced Service Accounts. We discussed this in #181, but at that moment the Go SDK did not support service accounts.
Earlier this week, 1Password announced new SDKs.
This PR adds support for retrieving secrets from 1Password using service accounts.
Example:
ref+op://vals-test/vals-test/usernameI have tested this locally and I have added the accompanying test, with setup instructions.
Closes #181