Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable connected ports, configure connectors and LLDP #114

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jbemmel
Copy link

@jbemmel jbemmel commented May 23, 2023

The use of connectors varies between SR OS variants, it is convenient if vrnetlab configures them and enables the ports with LLDP

@hellt
Copy link
Owner

hellt commented May 28, 2023

Hi @jbemmel
I would propose we make this an opt-out feature. There are use cases where users want to have a node with a +/- clean config, with ports not configured at all, as this might be the task they test/use.

So I think the easy opt-out way would be skip ports/breakout config if a certain env var is present. For example CLAB_CONFIG_SROS_PORTS=false.

@jbemmel
Copy link
Author

jbemmel commented May 28, 2023

Sure, we can add that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants