-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fallback for Current Version Detection" #62
base: master
Are you sure you want to change the base?
Conversation
Also, downloading an obsolete version could be bad for opsec... I think it would be better for it to fail... |
Then instead of reverting the previous commit, you should just point the URL to /obsolete/$VERSION |
I don't think we should encourage anyone to use the obsolete versions, they could contain exploitable security flaws. |
I guess we shouldn't encourage obsolete versions for the reasons @rmwb mentioned. But at the same time, we should not have the script break entirely if the filename is changed; that just seems very flimsy. Why don't we prompt the user asking them if they would like to use the older version (with an explanation of the ramifications of doing such) and use the /obsolete/$TAILS VERSION url? |
Yes prompting the user seems like a good middle ground. @rmwb seems reasonable? |
I really baulk at the potential security implications of installing an obsolete version. |
Regardless of how you plan to implement a fallback URL or not, this particular commit (#61) is poorly coded, will not work as intended and should really be reverted. |
@rmwb I don't see how you can claim that 2 lines of code are poorly coded. If we need to be honest this whole script is poorly coded and it's mainly my fault :P. One day it will all be refactored to be as shiny and perfect as diecut diamond, but that day is not today. 💎 Speaking of the future, this repository will hopefully one day disappear. I have been speaking to Intrigeri (one of the TAILS developers) about merging this effort into something officially supported by TAILS. From the looks of their latest documentation, they now make images that can just be dd'ied directly onto the drive: https://tails.boum.org/doc/first_steps/installation/manual/mac/index.en.html. I therefore ask myself does this repository still make sense to exist? |
Fine let's just let it fail gracefully then. At least this way someone will report that the script is broken on GitHub, so that it can be fixed. @rmwb, would you like to write the explanatory error message? |
Reverts #61
It won't work. The URLs will be broken.