Fixed Clean, Added Icon, Updated tested-on list #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Grezzo
commented
Dec 13, 2014
Grezzo
commented
- Fixed find command in clean section that was missing a dash
- Added a volume icon
- Updated results in tested-on list with info from issue 50. Issue 50 can be closed now
added 11 commits
December 10, 2014 11:20
Details gained from issue 50
This gives the USB disk a pretty Icon (the TAILS logo) in Finder and in the boot menu
Conflicts: tested-on.md Updated MacBookPro 8,1 to include wifi and trackpad results
Conflicts: create-image.sh Added a volume icon that makes finder and the boot menu show a TAILS logo instead of a generic USB disk image
Removed diff from bad commit
missing a couple of dashes before "path"
without this flag set the .VolumeIcon.icns file is ignored
Created from SVG available at https://tails.boum.org/promote/tails-sticker.svg with some changes for the smaller rasters
Automatically figure out what the latest version of TAILS is by parsing http://dl.amnesia.boum.org/tails/stable/
* Changed Volume Label from TAILSLIVECD to TAILSLIVE because it’s not a CD (and TAILSLIVEUSB is too long). * detach the tails iso when finished with it
* Commented out trace (debugging) command (`set -w`) * Removed `-k` switch from command that downloads iso because `-k` turns off cert checking, but it’s not even using https * Removed URL definitions from start because they are now automatically figured out, and they need to use curl now so should only really be done in `download_tails()` * Moved signature and key downloading to `download_tails()` because they required internet access and if the files were already in the data directory, they need not be performed, whereas `verify_tails()` always is.
|
I made some changes to my master branch since I made the pull request and they seem to have been included in the pull request. (Is that normal? How am I supposed to stop that from happening?) Anyway, I suppose I should explain what has been added to the pull request since my original comment:
|
|
Hi @Grezzo grezzo, apologies for not looking at this sooner. Could you perhaps rebase this against the current master and I will tend to it? Thanks! |
|
OK, working on it... |
|
I decided to add each change as a separate pull request. I think I've done it all except re-factoring the stuff that requires internet connections (so it can be used offline) and updating the tested-on list. I'll get round to these after the new pull requests are accepted/rejected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.