Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep estimated time display #819

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

JayJay1024
Copy link
Collaborator

@JayJay1024 JayJay1024 commented Sep 11, 2024

PR-Codex overview

The focus of this PR is to refactor the transfer-information.tsx component by improving the handling of the estimatedTime prop.

Detailed summary

  • Refactored the conditional rendering of the Estimated Arrival Time row
  • Updated the Row component props for Estimated Arrival Time to handle loading state more efficiently

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: e550f52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 11, 2024

@JayJay1024 JayJay1024 merged commit 8788684 into main Sep 11, 2024
2 checks passed
@JayJay1024 JayJay1024 deleted the jay/keep-estimated-time-display branch September 11, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant