Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Create MultiSigWallet.sol #76

Closed
wants to merge 2 commits into from

Conversation

YoshiyukiSakura
Copy link

this resolves helix-bridge/relayer#22

@YoshiyukiSakura YoshiyukiSakura changed the title Create MultiSigWallet.sol [WIP]Create MultiSigWallet.sol Jun 21, 2024
transactionSigners[hash].length < threshold,
"threshold reached"
);
require(
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think of let's directly validate signature here without storing signatures anywhere?
it looks safe to me, only signer with private keys can successfully pass this require check
meanwhile, storing less data can save us some gas gee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement our own MultisigWallet smart contract and deploy to target chains
1 participant