Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace lifetimes with Arc for CreateSmartTransactionConfig #89

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

grandima
Copy link
Contributor

@grandima grandima commented Nov 8, 2024

Closes #83
Wraps into Arc variables that were referenced with lifetime in CreateSmartTransactionConfig

Copy link

@mahmudsudo mahmudsudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely implemented

Copy link
Collaborator

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very based! Thank you for your contribution! 🔥

@0xIchigo 0xIchigo merged commit bd9e0b1 into helius-labs:dev Nov 26, 2024
1 check passed
@grandima grandima deleted the wip-lifetime-to-arc branch December 11, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework CreateSmartTransactionConfig to Resolve Lifetime Issues
3 participants