Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add send_and_confirm_transaction method and refactor transaction sending logic #87

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

Eliascm17
Copy link
Contributor

Description:

This PR introduces a new send_and_confirm_transaction method to handle transaction sending and confirmation in a more modular way. It also refactors the existing transaction sending logic in send_smart_transaction to use this new method, reducing code duplication and improving maintainability.

Changes:

  • Added new send_and_confirm_transaction method that accepts any transaction implementing SerializableTransaction
  • Added new method documentation to README.md
  • Refactored send_smart_transaction to use the new method
  • Improved code organization by removing duplicate transaction sending logic
  • Added SerializableTransaction import from solana_client

Copy link
Collaborator

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the way 🚀

@0xIchigo 0xIchigo merged commit ce06a59 into helius-labs:dev Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants