feat(enhanced websocket): Add transactionSubscribe and accountSubscribe
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xIchigo
changed the title
transactionSubscribe and accountSubscribe
0xIchigo
requested changes
May 16, 2024
There was a problem hiding this comment.
Very based! The code is solid overall, I just have a few nitpicks here and there that could improve its overall quality. Also, I've tested the examples with a few real-world calls and can ensure that it works as intended. If possible, it would be nice if you could write up some test cases for transactionSubscribe and accountSubscribe in a test/test_websocket.rs file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for geyser enhanced websockets.
There are two methods each with an example:
Tests pass, cargo fmt has been run, and all warnings have been cleaned.