Fix Config and Endpoints Update Breaking Tests

helius-labs · Apr 24, 2024 · 93b9ec3 · 93b9ec3
1 parent 053499b
commit 93b9ec3
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/src/config.rs b/src/config.rs
@@ -1,4 +1,4 @@
-use crate::error::Result;
+use crate::error::{ HeliusError, Result };
 use crate::types::{Cluster, HeliusEndpoints};
 
 #[derive(Clone)]
@@ -10,7 +10,12 @@ pub struct Config {
 
 impl Config {
     pub fn new(api_key: &str, cluster: Cluster) -> Result<Self> {
+        if api_key.is_empty() {
+            return Err(HeliusError::InvalidInput("API key cannot be empty".to_string()));
+        }
+
         let endpoints: HeliusEndpoints = HeliusEndpoints::for_cluster(&cluster);
+
         Ok(Config {
             api_key: api_key.to_string(),
             cluster,

diff --git a/tests/test_config.rs b/tests/test_config.rs
@@ -15,6 +15,6 @@ fn test_config_new_with_valid_api_key() {
 
     let config: Config = result.unwrap();
     assert_eq!(config.api_key, "valid-api-key");
-    assert_eq!(config.endpoints.api, "https://api-devnet.helius-rpc.com");
-    assert_eq!(config.endpoints.rpc, "https://devnet.helius-rpc.com");
+    assert_eq!(config.endpoints.api, "https://api-devnet.helius-rpc.com/");
+    assert_eq!(config.endpoints.rpc, "https://devnet.helius-rpc.com/");
 }
diff --git a/tests/test_factory.rs b/tests/test_factory.rs
@@ -7,8 +7,8 @@ fn test_factory_create_devnet_instance() {
     let helius: Helius = factory.create(Cluster::Devnet).unwrap();
 
     assert_eq!(helius.config.api_key, "valid_api_key");
-    assert_eq!(helius.config.endpoints.api, "https://api-devnet.helius-rpc.com");
-    assert_eq!(helius.config.endpoints.rpc, "https://devnet.helius-rpc.com");
+    assert_eq!(helius.config.endpoints.api, "https://api-devnet.helius-rpc.com/");
+    assert_eq!(helius.config.endpoints.rpc, "https://devnet.helius-rpc.com/");
 }
 
 #[test]
@@ -17,6 +17,6 @@ fn test_factory_create_mainnet_instance() {
     let helius: Helius = factory.create(Cluster::MainnetBeta).unwrap();
 
     assert_eq!(helius.config.api_key, "valid_api_key");
-    assert_eq!(helius.config.endpoints.api, "https://api-mainnet.helius-rpc.com");
-    assert_eq!(helius.config.endpoints.rpc, "https://mainnet.helius-rpc.com");
+    assert_eq!(helius.config.endpoints.api, "https://api-mainnet.helius-rpc.com/");
+    assert_eq!(helius.config.endpoints.rpc, "https://mainnet.helius-rpc.com/");
 }