Merge pull request #138 from heidelpay/MAGE2-316/fix/shipping_order_s…

…tate

(MAGE2-316)[fix] Set expected orderstate after shipment for invoice

CHANGELOG.md

@@ -10,6 +10,7 @@ This project does not follow a versioning standard. Versions are crafted after t
 for secured payment methods and PayPal.
 - Disable caching for dynamic blocks.
 - An issue creating orders from Reservations.
+- Invoice Payment methods : An issue not always setting the expected state after shipment.
 
 ## 20.2.24
 ### Added

Controller/Adminhtml/Order/Shipment/Save.php

@@ -131,8 +131,8 @@ public function beforeExecute()
 
                 // if the response isn't successful, redirect back to the order view.
                 if (!$heidelpayMethod->getResponse()->isSuccess()) {
-                    $this->messageManager->addErrorMessage(
-                        __('Heidelpay Error at sending Finalize Request. The Shipment was not created.')
+                    $this->messageManager->addWarningMessage(
+                        __('Heidelpay Error at sending Finalize Request. The Shipment was created.')
                         . ' Error Message: ' . $heidelpayMethod->getResponse()->getError()['message']
                     );
 
@@ -142,16 +142,14 @@ public function beforeExecute()
                     );
 
                     $this->_redirect('*/*/new', ['order_id' => $this->getRequest()->getParam('order_id')]);
+                } else {
+                    $order->addStatusHistoryComment('heidelpay - Finalizing Order');
+                    $this->messageManager->addSuccessMessage(__('Shipping Notification has been sent to Heidelpay.'));
                 }
 
-                // set order state to "pending payment"
-                $state = Order::STATE_PENDING_PAYMENT;
-                $order->setState($state)->addStatusHistoryComment('heidelpay - Finalizing Order', true);
-
-                $this->orderResository->save($order);
-
-                $this->messageManager->addSuccessMessage(__('Shipping Notification has been sent to Heidelpay.'));
             }
+            $method->setShippedOrderState($order);
+            $this->orderResository->save($order);
         }
     }
 }

PaymentMethods/HeidelpayAbstractPaymentMethod.php

@@ -889,6 +889,14 @@ public function getUseShippingAddressAsBillingAddress()
         return $this->useShippingAddressAsBillingAddress;
     }
 
+    /**
+     * Define order status after shipment.
+     * @param $order
+     */
+    public function setShippedOrderState(&$order)
+    {
+    }
+
     /**
      * Load the payment information by store id, customer email address and payment method of the quote
      *

PaymentMethods/HeidelpayInvoicePaymentMethod.php

@@ -15,6 +15,7 @@
 
 use Exception;
 use Heidelpay\Gateway\Block\Info\Invoice as InvoiceBlock;
+use Heidelpay\Gateway\Traits\CanShipBeforePayment;
 use Heidelpay\PhpPaymentApi\Exceptions\UndefinedTransactionModeException;
 use Heidelpay\PhpPaymentApi\PaymentMethods\InvoicePaymentMethod;
 use Magento\Sales\Model\Order;
@@ -27,6 +28,8 @@
  */
 class HeidelpayInvoicePaymentMethod extends HeidelpayAbstractPaymentMethod
 {
+    use CanShipBeforePayment;
+
     /** @var string Payment Code */
     const CODE = 'hgwiv';
 

PaymentMethods/HeidelpayInvoiceSecuredPaymentMethod.php

@@ -15,6 +15,7 @@
 
 use Heidelpay\Gateway\Block\Info\InvoiceSecured as InvoiceSecuredBlock;
 use Heidelpay\Gateway\Model\PaymentInformation;
+use Heidelpay\Gateway\Traits\CanShipBeforePayment;
 use Heidelpay\PhpPaymentApi\Exceptions\UndefinedTransactionModeException;
 use Heidelpay\PhpPaymentApi\PaymentMethods\InvoiceB2CSecuredPaymentMethod;
 use Magento\Quote\Api\Data\CartInterface;
@@ -28,6 +29,7 @@
  */
 class HeidelpayInvoiceSecuredPaymentMethod extends HeidelpayAbstractPaymentMethod
 {
+    use CanShipBeforePayment;
     /** @var string Payment Code */
     const CODE = 'hgwivs';
 

PaymentMethods/Traits/CanShipBeforePayment.php

@@ -0,0 +1,33 @@
+<?php
+/**
+ * Trait to handle payment methods that can ship before payment e.g. Invoice.
+ *
+ * @license Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
+ * @copyright Copyright © 2016-present heidelpay GmbH. All rights reserved.
+ * @link http://dev.heidelpay.com/magento2
+ * @author David Owusu
+ *
+ * @package heidelpay
+ * @subpackage magento2
+ * @category magento2
+ */
+
+namespace Heidelpay\Gateway\Traits;
+
+
+use Magento\Sales\Model\Order;
+
+trait CanShipBeforePayment
+{
+    /**
+     * @param Order $order
+     */
+    public function setShippedOrderState(&$order)
+    {
+        if ($order->getTotalPaid() < $order->getGrandTotal()) {
+            $state = Order::STATE_PENDING_PAYMENT;
+            $status = $order->getConfig()->getStateDefaultStatus($state);
+            $order->setState($state)->setStatus($status);
+        }
+    }
+}