Skip to content

Commit

Permalink
Merge pull request #231 from VisLab/update-tokenizer
Browse files Browse the repository at this point in the history
This PR represents the first version of the completed validator for version 4.0.0. All features have been implemented.

This version only supports the BIDS non-legacy (schema-based) version of the BIDS validator.:
- The JSON spec tests as well as the hed-validator tests run. 
- Validation based on JSON properties of the reserved tags has been fully implemented.
- Validation of temporal behavior including `Delay` has been implemented.
- The internal tests have been converted to use separate test data objects for readability and ease in adding new tests.

**Summary of the philosophical changes:**
- Errors are detected as early as possible with early exit.  For example the first stage is the Tokenizer which detects many parsing errors that were previously only detected at later validation stages.
- Normalized representations of the primary objects (tag, group, and string) are built at construction time so that duplicates are detected when hedstrings is constructed.

TODO:
1. Additional tests are to be added.
2. The old validator code directory will be removed in the next round of PRs.
3. The removal from step 2 will result in additional unused methods in other classes that will be removed.

The original PR was reverted because an extraneous directory was present.
  • Loading branch information
VisLab authored Dec 23, 2024
2 parents 562cf42 + e6b558d commit 7e28d43
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 7e28d43

Please sign in to comment.