x86: implement CPUID 15h support #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heatd
requested changes
Nov 29, 2024
kernel/arch/x86_64/apic.cpp
Outdated
|
|
||
| for (int i = 0; i < CALIBRATION_TRIALS; i++) | ||
| { | ||
| apic_calibrate(i); | ||
| if (calibrate_apic) | ||
| { |
There was a problem hiding this comment.
Don't add {} around single-statement ifs
kernel/arch/x86_64/apic.cpp
Outdated
|
|
||
| for (int i = 0; i < 3; i++) | ||
| { | ||
| deltas[i] = calib.apic_ticks[i]; | ||
| } | ||
|
|
||
| apic_rate = calculate_frequency(deltas, 1); | ||
| if (calibrate_apic) | ||
| { |
kernel/arch/x86_64/cpu.cpp
Outdated
| { | ||
| if (ebx == 0 || eax == 0) | ||
| { | ||
| INFO("x86cpu", "CPUID 0x15 is useless, reverting to calibration\n"); |
There was a problem hiding this comment.
Same single-brace statement (apply to elsewhere in the review)
Don't use INFO but pr_info (maybe pr_info("x86: ..."))
There was a problem hiding this comment.
I think it would be better to get rid of INFO in this and other files in a separate PR
There was a problem hiding this comment.
I'm not asking you to get rid of all INFOs, just don't add new ones
heatd
reviewed
Nov 29, 2024
kernel/arch/x86_64/cpu.cpp
Outdated
| /* Some Intel SoCs don't report crystal clock. Though it can be | ||
| * highly accurately calculated from CPU base frequency | ||
| */ | ||
| auto numerator = ebx; |
|
Also, please rebase on top of master! |
|
You have conflicts with master after my latest merge. Also small nit: s/x86_64/x86/ |
petershh
changed the title
|
I renamed cpu to bootcpu_info, btw |
This allows us to get TSC and APIC rates without calibration on processors supporting this leaf. Signed-off-by: Peter Shkenev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to get TSC and APIC rates without calibration on processors supporting this leaf.