Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-shell: add node shell plugin #133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

farodin91
Copy link

@farodin91 farodin91 commented Dec 14, 2024

image
image
image

Fixes headlamp-k8s/headlamp#996

Possible Improvements:

  • ensure pod is running
  • improve error handling
  • ensure pod is stopped
  • add testing
  • Windows Support

@farodin91 farodin91 marked this pull request as ready for review December 14, 2024 13:43
@farodin91
Copy link
Author

@joaquimrocha Would you like to review?

Copy link
Contributor

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works very well! Thanks @farodin91 .
I am still torn between having it as a plugin or having it in the core, but since it shouldn't work in certain environments, maybe it's better as a plugin.

I also realized that we should make it easier for plugins to declare cluster-based settings. These would show up both in the plugin settings, with the cluster selector already automatically done for them, and in the cluster's own settings, as sections.

Since I am leaving on vacation for 2 weeks, I will leave a deeper review of the code to @illume .

@farodin91 farodin91 force-pushed the add-node-shell-plugin branch from 44a383a to d8eaac9 Compare December 29, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for execing into a node
2 participants