Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Small table fixes and improvements #2661

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Conversation

sniok
Copy link
Contributor

@sniok sniok commented Dec 11, 2024

  1. Fix name column value in Role list
    Search by Role name now works

  2. Fix searching error when some items don't have a namespace
    Go to roles, search, it now works and doesn't silently print errors in console

  3. Fix per column filtering not working
    This is a regression. This button now works
    image

  4. Make checkboxes smaller and fixed width
    Just a small cosmetic improvement

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 11, 2024
@sniok sniok added frontend Issues related to the frontend regression Bugs for things that used to work in previous releases. bug Something isn't working and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 11, 2024
@sniok sniok requested a review from a team December 11, 2024 16:06
@joaquimrocha joaquimrocha added this to the v0.27.0 milestone Dec 11, 2024
Copy link
Collaborator

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 11, 2024
@joaquimrocha
Copy link
Collaborator

Merging since the failed tests are not introduced by this PR.

@joaquimrocha joaquimrocha merged commit d3a0f25 into main Dec 11, 2024
16 of 18 checks passed
@joaquimrocha joaquimrocha deleted the small-table-fixes branch December 11, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Issues related to the frontend lgtm This PR has been approved by a maintainer regression Bugs for things that used to work in previous releases.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants