Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: refactor row action menus #2621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

frontend: refactor row action menus #2621

wants to merge 1 commit into from

Conversation

farodin91
Copy link
Contributor

@farodin91 farodin91 commented Nov 30, 2024 •
edited
Loading

  • only show view or edit
  • move function out of resourcetable to make it more readable
  • Merge Row actions menus and details view header actions

@farodin91 farodin91 changed the title cleanup actions frontend: refactor row action menus Dec 4, 2024
@farodin91 farodin91 marked this pull request as ready for review December 4, 2024 18:15
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 4, 2024
joaquimrocha
joaquimrocha reviewed Dec 6, 2024
View reviewed changes
frontend/src/components/common/Resource/index.test.ts Outdated
@@ -27,6 +27,7 @@ const checkExports = [
'ResourceListView',
'ResourceTable',
'resourceTableSlice',
'ResourceTableSingleActions',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should actually be exported.

joaquimrocha
joaquimrocha requested changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about backward compatibility. Also check out the unsorted imports.

frontend/src/components/common/Resource/ResourceTable.tsx
Comment on lines -87 to +86
actions?: null | RowAction[];
actions?: null | HeaderAction[];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to leave this with the previous type because plugins may be using it and it would mean a type break for them.

@farodin91
Copy link
Contributor Author

@joaquimrocha I merged header and row action to make the equal. What do you think?

@farodin91 farodin91 mentioned this pull request Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquimrocha joaquimrocha joaquimrocha requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farodin91 @joaquimrocha