-
Notifications
You must be signed in to change notification settings - Fork 188
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Evangelos Skopelitis <[email protected]>
- Loading branch information
Showing
40 changed files
with
210 additions
and
206 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,9 +15,9 @@ Please refer to the Kinvolk [Code of Conduct](https://github.com/kinvolk/contrib | |
|
||
## Development practices | ||
|
||
The Headlamp project follows the [Kinvolk Contribution Guidelines](https://github.com/kinvolk/contribution) | ||
The Headlamp project follows the [Kinvolk Contribution Guidelines](https://github.com/kinvolk/contribution), | ||
which promotes good and consistent contribution practices across Kinvolk's | ||
projects. Before start contributing, and in addition to this section, please | ||
projects. Before starting to contribute, and in addition to this section, please | ||
read those guidelines. | ||
|
||
## Filing an issue or feature request | ||
|
@@ -28,7 +28,7 @@ you think are useful. | |
### Security issues | ||
|
||
For filing security issues that are sensitive and should not be public, please | ||
send an email to [email protected] . | ||
send an email to <[email protected]> . | ||
|
||
## Translations | ||
|
||
|
@@ -38,7 +38,7 @@ dedicated [i18n docs](./development/). | |
### Complex contributions | ||
|
||
If you have a complex contribution in mind (meaning changes in the architecture | ||
or a lot of LOC changed), it is advisable to first file a Github issue and | ||
or a lot of LOC changed), it is advisable to first file a GitHub issue and | ||
discuss the implementation with the project's maintainers. | ||
|
||
## Coding style | ||
|
@@ -65,13 +65,13 @@ the CI checks are passing for your PR. | |
|
||
## Commit guidelines | ||
|
||
For the general guidelines on making PRs/commits easier to review, please check | ||
For general guidelines on making PRs/commits easier to review, please check | ||
out Kinvolk's | ||
[contribution guidelines on git](https://github.com/kinvolk/contribution/tree/master/topics/git.md). | ||
|
||
## Testing | ||
|
||
The frontend is tested via Storybook related snapshots. So new components should have | ||
The frontend is tested via Storybook-related snapshots. So new components should have | ||
an associated story when possible. | ||
|
||
For running the frontend tests, use the following command: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.