-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WAN publisher description #926
Conversation
|
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/modules/wan/pages/wan.adoc
Outdated
Most often, this is a single, entire target Hazelcast cluster but you can also define custom publishers which | ||
may transmit WAN events to other systems such as messaging queues, Kafka or even persist events on disk. | ||
* WAN publisher: A publisher acts as a sink for local WAN events and pushes them to a target. The target is usually | ||
another Hazelcast cluster, but can be customized to be another system, such as a messaging queue, Kafka or even persisted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The target is usually another Hazelcast cluster; however, you could also use a different target such as a message queue, Kafka, or saving data to persistent storage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions not related to the update, but as I looked and saw it....
- Can we link to any docs on WanReplicationPublisher? If not, what does it add to tell me that this is an implementation of it?
- Can we link to any information on using different targets? Possibly the Configuring WAN Replication page, and/or Advanced Features?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rebekah-lawrence, your tweaks read better.
@JamesHazelcast or @vbekiaris may have some suggestions about informative links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"different targets" like JMS etc are examples of custom WanPublisher
implementations a user can implement, it's not something we support out of the box. To be honest, I have never seen a user/customer implement their own WanPublisher
.
The WanReplicationPublisher
name is probably outdated - the interface is called WanPublisher
and it's what users should implement to provide their custom WAN publisher implementation. Probably the audience here would be a java developer, so I think it would be most appropriate to link to WanPublisher
javadoc
docs/modules/wan/pages/wan.adoc
Outdated
and so on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest recasting the previous two sentences (the second is really only a phrase and the last three words that were deleted and re-added don't make sense in it); something like:
For example, you could use the WAN Publisher ID as follows:
+
- In combination with the WAN replication scheme name to pause, stop, or resume WAN replication for a specific publisher
- To trigger synchronization with a specific target cluster
No description provided.