Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document required permission for Hazelcast Management Center #1410

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

userMuratt
Copy link

No description provided.

@userMuratt userMuratt requested a review from a team as a code owner December 2, 2024 08:28
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit 1165ff6
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/674d7b36fe9ad10008794239
😎 Deploy Preview https://deploy-preview-1410--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Rob-Hazelcast Rob-Hazelcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once those suggestions are applied. Thanks!

@@ -191,6 +191,8 @@ The following is the list of client permissions that can be configured on the me
=== All permissions

The `<all-permissions>`` permission grants clients access to all data and features.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `<all-permissions>`` permission grants clients access to all data and features.
`<all-permissions>` grants clients access to all data and features.

@@ -191,6 +191,8 @@ The following is the list of client permissions that can be configured on the me
=== All permissions

The `<all-permissions>`` permission grants clients access to all data and features.
The client specified in the following code example is used by Hazelcast Management Center when it connects to clusters.
To learn more about this client, see xref:{page-latest-supported-mc}@management-center:ROOT:connecting-members.adoc[].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't have link text in the preview build. The existing link looks fine on the live site so this should too, but please check once this update goes live (a few minutes after the changes are merged).

The client specified in the following code example is used by Hazelcast Management Center
when it connects to clusters. To learn more about this client, see xref:{page-latest-supported-mc}@management-center:ROOT:connecting-members.adoc[].

WARNING: For Hazelcast Management Center to work properly, `management-permission` is not sufficient, `all-permissions` is required.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WARNING: For Hazelcast Management Center to work properly, `management-permission` is not sufficient, `all-permissions` is required.
WARNING: For Hazelcast Management Center to work properly, `management-permission` is not sufficient. `all-permissions` is required.

@@ -223,8 +225,8 @@ all:

The `<management-permission>`` permission defines which
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `<management-permission>`` permission defines which
`<management-permission>` defines which

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants