Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize backport.yml #1403

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Optimize backport.yml #1403

merged 1 commit into from
Nov 26, 2024

Conversation

zhmaeff
Copy link
Contributor

@zhmaeff zhmaeff commented Nov 26, 2024

Use ENV var instead of empty job with output.

Use ENV var instead of empty job with output.
@zhmaeff zhmaeff self-assigned this Nov 26, 2024
@zhmaeff zhmaeff requested a review from a team as a code owner November 26, 2024 10:29
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit 72639f7
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/6745a2f37f544e00080cd890
😎 Deploy Preview https://deploy-preview-1403--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@JackPGreen JackPGreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nicer, thanks!

Could you do the same in hazelcast-platform-operator as well, please?

@zhmaeff zhmaeff enabled auto-merge (squash) November 26, 2024 12:03
zhmaeff added a commit to hazelcast/hazelcast-platform-operator-docs that referenced this pull request Nov 26, 2024
Use ENV var instead of empty job with output.
See hazelcast/hz-docs#1403
@zhmaeff zhmaeff merged commit 8e4133c into main Nov 26, 2024
6 checks passed
@zhmaeff zhmaeff deleted the remove-redundant-job branch November 26, 2024 19:07
zhmaeff added a commit that referenced this pull request Nov 27, 2024
JackPGreen added a commit that referenced this pull request Nov 27, 2024
JackPGreen added a commit that referenced this pull request Nov 27, 2024
Reverts #1403

[`env` is only available in workflow _`steps`_, so isn't accessible for
matrix specification](https://stackoverflow.com/a/74073435).

Fixes:
hazelcast/hazelcast-platform-operator-docs#277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants