Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-279: add blog link and description to page #1401

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

oliverhowell
Copy link
Contributor

No description provided.

@oliverhowell oliverhowell added the backport to 5.5 Backport commits from main to v/5.5 label Nov 25, 2024
@oliverhowell oliverhowell requested a review from a team as a code owner November 25, 2024 15:46
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit 7b301fc
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/67449bceb2130f0008f7b0e8
😎 Deploy Preview https://deploy-preview-1401--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for hardcore-allen-f5257d ready!

Name Link
🔨 Latest commit 1a49dc6
🔍 Latest deploy log https://app.netlify.com/sites/hardcore-allen-f5257d/deploys/6747226c83f8a400086be262
😎 Deploy Preview https://deploy-preview-1401--hardcore-allen-f5257d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Rob-Hazelcast Rob-Hazelcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks good.

The padding around the first image isn't ideal, but I see you've got another PR for that.

I think the call-out box is appropriate, it's just a little unfortunate that it's labelled "Tip" under the heading "Tips". Might be nice to change that heading. Not a big deal though.

@oliverhowell
Copy link
Contributor Author

I think the call-out box is appropriate, it's just a little unfortunate that it's labelled "Tip" under the heading "Tips". Might be nice to change that heading. Not a big deal though.

Yeah, maybe just a note would be slightly better? I didn't want to introduce new nomenclature but agree Tip not ideal...

@Rob-Hazelcast
Copy link
Contributor

I think the call-out box is appropriate, it's just a little unfortunate that it's labelled "Tip" under the heading "Tips". Might be nice to change that heading. Not a big deal though.

Yeah, maybe just a note would be slightly better? I didn't want to introduce new nomenclature but agree Tip not ideal...

No strong feelings on the best option. Change the heading, change the callout box to a note, or get rid of the callout box. If you did change the heading, you could go for "Best practice" or something like "Getting the most out of Ask AI" or "Help us help you".

@oliverhowell oliverhowell merged commit 35bb16f into hazelcast:main Nov 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to 5.5 Backport commits from main to v/5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants