Reusable action for docs deployment #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JackPGreen
reviewed
Nov 25, 2024
.github/actions/deploy/action.yml
Outdated
There was a problem hiding this comment.
I think this should be a re-usable action (workflow_call) as it's not a step you'd want to use in conjunction with anything else. Plus that would mean you could centralise the runs-on definition.
I also don't think you can use relative paths with composite actions without a checkout first. But I could be wrong.
JackPGreen
reviewed
Nov 25, 2024
| runs-on: ubicloud-standard-2 | ||
| steps: | ||
| - name: Dispatch docs deployment | ||
| run: curl -X POST -d {} https://api.netlify.com/build_hooks/60e71936b15bb431b42b698a |
There was a problem hiding this comment.
Nit - a link to the netlify documentation that specifies this command might help to avoid someone wondering what it does.
JackPGreen
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.