Update IHMap.Setting.cs #931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix order of parameters on interface compared to implementation
|
|
|
Hi @rejdzu, thank you for your contribution ❤️. Although it's a nice touch, I can't merge it know because it will break backward compatibility. Also, the implementation should be refactored accordingly. I've put it to backlog. Whenever there is chance to break backward compatibility, I'll process it ✋ |
emreyigit
added
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix order of parameters on interface compared to implementation
Issue: Interface of the HMap has different order of parameters than the implementation, which is causing confusion and wrong behavior