chore: fix off-by-one error with jinja loop index #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcgleenon
force-pushed
the
fixed-event-message-type
branch
from
9a5b86a to
a56db81
Compare
|
@ihsandemir @JamesHazelcast here's a quick bug fix could you plz take a look? |
JamesHazelcast
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed off-by-one error in Event message_type. According to the protocol the Least significant bit is set to 0 (Request), 1 (Response) and increments for each Event.
Message Type value for MembersView should end in 02, PartitionsView -> 03, MemberGroupsView -> 04
Instead it is off by 1 since the jinja loop.index starts at 1 not 0