Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Add Docker Healthcheck to both containers. #893

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GAS85
Copy link

@GAS85 GAS85 commented May 7, 2024

What type of PR is this?

  • feature

What this PR does / why we need it:

This PR introduced Docker Healthcheck to normal and rootless containers. It is Based on GoogleContainerTools/distroless#183 (comment)

Which issue(s) this PR fixes:

Fixes #890

Special notes for your reviewer:

You asked for PR 😄

Testing

Container was build and after 30 Seconds marked as healthy. Also GET request to the / can be seen in the logs.

Release Notes

- Add `wget` to `rootless` container.
- Introduced Healthcheck to containers.

@zodac
Copy link
Contributor

zodac commented Jun 2, 2024

I think it might be better to hit the status endpoint, rather than just the root URL? At http://localhost:7745/api/v1/status, for example.

@GAS85
Copy link
Author

GAS85 commented Jun 2, 2024

Didn't know about this endpoint. Hope it returns anything else than 200 if not healthy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add healthcheck to container or to example
2 participants