support buying xmr without deposit or fee using passphrase #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodser
force-pushed
the
deployment
branch
2 times, most recently
from
4bca41c to
e6023c0
Compare
|
Are you planning to set a 0.11xmr cap on this so its only use is nocoiners? Edit: if so
|
|
cap should be 0.5 XMR or a bit lower, maybe 0.25. 0.11 is already annoyingly low if you have no xmr and want to put for example $300 into it (because you need multiple trades to just get the minimum deposit amount). |
woodser
force-pushed
the
deployment
branch
2 times, most recently
from
e14a174 to
2b02824
Compare
woodser
changed the title
|
Limit set to 0.5 XMR for no deposit offers with passphrase. |
woodser
force-pushed
the
deployment
branch
4 times, most recently
from
8cdf725 to
5d2e157
Compare
|
Hey, the version that implements this will be a mandatory upgrade correct. It seems like it would be a change to the protocol and therefore require all clients to upgrade. |
|
Yeah it's best to be a mandatory update, otherwise trades will fail if non updated clients try taking the new offer type. |
woodser
force-pushed
the
deployment
branch
2 times, most recently
from
a01cf73 to
f8a8407
Compare
woodser
changed the title
|
Limit bumped to 1 XMR from this conversation: #1464 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.