Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip unknown platforms for hauler save manifest.json #326

Closed
wants to merge 3 commits into from

Conversation

amartin120
Copy link
Contributor

@amartin120 amartin120 commented Sep 20, 2024

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

Types of Changes:

  • bugfix

Proposed Changes:

  • When constructing the manifest.json for use with docker load, if a multi-arch image contains a platform defined as "unknown/unknown" (looking at you, busybox), docker fails to load.

Verification/Testing of Changes:

Additional Context:

@amartin120 amartin120 marked this pull request as draft September 20, 2024 23:59
@zackbradys
Copy link
Member

zackbradys commented Sep 21, 2024

Testing current commits/state of this PR here -> https://github.com/zackbradys/rancher-airgap/actions/runs/10969610724

@zackbradys zackbradys added enhancement New feature or request size/S Denotes an issue/PR requiring a relatively small amount of work bug Something isn't working and removed enhancement New feature or request labels Sep 21, 2024
@zackbradys zackbradys added this to the Hauler v1.1.0 milestone Sep 21, 2024
@amartin120
Copy link
Contributor Author

Closing this attempt. This causes bad things.

@amartin120 amartin120 closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes an issue/PR requiring a relatively small amount of work
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

2 participants