feat: add server config cache #48
Closed
+52
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatoo
requested changes
Jul 30, 2024
src/tls.rs
Outdated
| use dashmap::{try_result::TryResult, DashMap}; | ||
| use rustls::ServerConfig; | ||
|
|
||
| static SERVER_CONFIG_CACHE: LazyLock<DashMap<String, rustls::ServerConfig>> = LazyLock::new(|| DashMap::new()); |
There was a problem hiding this comment.
Caches should be held for each MitmProxy instance to support multiple proxy servers with different root certs.
Currently, it may cache a cert for different root cert
There was a problem hiding this comment.
I've pushed a commit to fix this, please re-check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve TODO and improve performance.
NOTICE: this need rust 1.80's LazyLock feature.