fix: Bump the Tutor version dependency to >=16.1.7 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rely on the Tutor OPENEDX_COMMON_VERSION variable to determine the tag (or branch) to fetch for the Tubular repository. In Tutor 16.1.6, the default value for OPENEDX_COMMON_VERSION changed from open-release/palm.3 to open-release/palm.4. This means we now need a version bump in our own install_requires list, so that we require Tutor>=16.1.6. However, the Tutor 16.1.6 package as published to PyPI contains a bug that makes it uninstallable, so we have to require Tutor>=16.1.7 instead. References: https://github.com/overhangio/tutor/releases/tag/v16.1.6 overhangio/tutor#943
|
@mrtmm With Tutor 16.1.7 having been released this no longer breaks, so this is good for review now. |
fghaas
changed the title
mrtmm
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely on the Tutor
OPENEDX_COMMON_VERSIONvariable to determine the tag (or branch) to fetch for the Tubular repository.In Tutor 16.1.6, the default value for
OPENEDX_COMMON_VERSIONchanged fromopen-release/palm.3toopen-release/palm.4. This means we now need a version bump in our owninstall_requireslist, so that we require Tutor>=16.1.6.However, the Tutor 16.1.6 package as published to PyPI contains a bug that makes it uninstallable, so we have to require Tutor>=16.1.7 instead.
References:
https://github.com/overhangio/tutor/releases/tag/v16.1.6
overhangio/tutor#943