Parenthesize negative numbers in ToField instances
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of a lazy text builder dates back to 87135c1, when scientific-0.2.0.2 only provided that option. Now we require scientific >= 0.3.7.0, which also provides the `ByteString` builder.
This is necessary because in PostgreSQL, `-` is a unary operator that has lower precedence than the `::` operator, and that can cause problems at the edge of allowed ranges. For example, `-32768::int2` is parsed as `-(32768::int2)`, which throws an "out of range" error, even though `(-32768)::int2` is accepted. Closes haskellari#143.
|
Ah, I saw there were no tests of I've added a test now, let me know if you want something more thorough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143.
This also switches the
Scientificinstance to use aByteStringbuilder instead of aText.Lazybuilder. Lazy text dates back to 87135c1, when scientific-0.2.0.2 only provided that option. Now we require scientific >= 0.3.7.0, which also provides theByteStringbuilder. The alternative was to reimplementparenNegativesfor this instance, which also wouldn't be too bad.For types with signed zeros,
-0isn't parenthesized. I wasn't sure how to detect it ("check whether the rendered value starts with-" should work but breaking out ofBuilderfeels bad for performance?), and I'm not aware of any situation where-(0::type)would be different than(-0)::type. I could easily imagine I'm missing something though.