Add strictness tests for IntMap construction #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing on #1061 (the test checks for the desired non-erroring behavior). |
meooow25
force-pushed
the
intmap-construct-strictness-tests
branch
from
01b448a
to
c713478
Compare
This aims to reduce the chance of introducing strictness bugs. Since we use the same IntMap type for lazy and strict maps, it is not possible to ensure appropriate strictness at the type level. So we turn to property tests. This follows similar tests implemented for Map.
meooow25
force-pushed
the
intmap-construct-strictness-tests
branch
from
c713478
to
4bb5eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1019.
Follows #1021.