Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add basic CI functionality #88

Merged
merged 4 commits into from
Dec 15, 2020
Merged

add basic CI functionality #88

merged 4 commits into from
Dec 15, 2020

Conversation

Anton-Latukha
Copy link
Contributor

@Anton-Latukha Anton-Latukha commented Dec 14, 2020 •
edited
Loading

This is what can be directly ported from HNix OR Haskell-With-Nixpkgs projects.

Nix testing held back because Haskell.Lib API interface can not be ported directly into Store Nix setup. In Nix it is ugly to pass/inherit API through imports, (API passes through essentially by restating API two more times in every file layer).

Thou, Nixpkgs integration test works directly.

In the near future, I going to migrate the Nixpkgs integration test into Haskell-Nix.

@Anton-Latukha
Copy link
Contributor Author

Now I would change the triggers to run on Push, to test workflows inside the PR.

@Anton-Latukha Anton-Latukha marked this pull request as draft December 14, 2020 15:50
@sorki
Copy link
Member

sorki commented Dec 14, 2020

Neat. I think you can try using cabal.project to add cryptohash-sha512 PR haskell-hvr/cryptohash-sha512#5 temporarily (https://cabal.readthedocs.io/en/3.4/cabal-project.html#specifying-packages-from-remote-version-control-locations).

@Anton-Latukha Anton-Latukha force-pushed the 2020-12-14-CI branch 9 times, most recently from b7254b6 to c7435b8 Compare December 15, 2020 10:09
@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Dec 15, 2020 •
edited
Loading

Nixpkgs integration action moved into #89, action code needs some adjustments to support monorepo.

@Anton-Latukha Anton-Latukha mentioned this pull request Dec 15, 2020
Closed
@Anton-Latukha
Copy link
Contributor Author

#88 (comment) moved into: #90.

@Anton-Latukha
Copy link
Contributor Author

CI works right.
All situations that are left - are of project code/configuration and do not relate to CI configuration.

ghc: could not execute: tasty-discover - is a project code/configuration situation, over the Internet, there are reports that is a syndrome of internal things.

@Anton-Latukha
Copy link
Contributor Author

Rolling the action triggers back to what they should from within the master branch.

@Anton-Latukha Anton-Latukha marked this pull request as ready for review December 15, 2020 10:25
@sorki
Copy link
Member

sorki commented Dec 15, 2020

Maybe you can cabal install tasty-discover

@Anton-Latukha
Copy link
Contributor Author

It already gets installed by the Cabal during the build.

@Anton-Latukha
Copy link
Contributor Author

Interesting, nowhere in the official tasty-discover doc is said that it works over the executable that should be installed into the PATH.

@Anton-Latukha Anton-Latukha mentioned this pull request Dec 15, 2020
Closed
@Anton-Latukha
Copy link
Contributor Author

You were right.

It is my first, maybe second, passing-by/meating tasty-discover. Opened Report for them so they mention the setup.

@Anton-Latukha
Copy link
Contributor Author

Store-remote test suite also requires Nix to be installed.

@Anton-Latukha
Copy link
Contributor Author

Done.

@Anton-Latukha Anton-Latukha merged commit d8db986 into master Dec 15, 2020
@Anton-Latukha Anton-Latukha deleted the 2020-12-14-CI branch December 15, 2020 12:02
@Anton-Latukha Anton-Latukha mentioned this pull request Dec 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anton-Latukha @sorki