This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Fix #312: Refactor Builder to support possibility of failure. #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jship
changed the title
vincenthz
reviewed
Jun 15, 2017
| ) | ||
| case runST $ Encoder.convertFromTo enc EncoderUTF8 (Vec.recast bytes) of | ||
| -- TODO: Don't swallow up specific error (second element of pair) | ||
| -- TODO: Confused why all this recasting is necessary. I "typed hole"-ed my way to get this function to compile. Feels like there should be a cleaner method. |
There was a problem hiding this comment.
we discussed this, and the original recast was a bad idea in the first place. so we'll sort this out with a overall of the decoder that I outlined in #353
In this case instead of recasting the array, you should downcast the Offset back to Word8 unit, so that you can splice the original array in 2 more efficiently.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started during ZuriHac 2017 with @Tiltman. Fixes #312.