Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

added Serialize instance for EndPointAddress #1

Closed
wants to merge 1 commit into from

Conversation

robstewart57
Copy link

Adds a Serialize instance for EndPointAddress. This adds binary serialization support using the cereal package, on top of the existing support for the binary package with the Binary instance.

@edsko , could you take a look at this when you get a chance? There might be a good reason that this is not currently in Network.Transport that I am not aware of?

@hyperthunk
Copy link
Member

I'm happy to merge this if @edsko agrees it's okay to take the extra dependency. @edsko @dcoutts thoughts?

@ghost ghost assigned edsko Mar 15, 2013
@edsko
Copy link
Member

edsko commented Mar 16, 2013

This is one for @dcoutts I think -- he tends to care more about dependencies :)

@dcoutts
Copy link
Member

dcoutts commented Mar 25, 2013

If we can avoid it, I'd rather not. As far as I know, there are now no good reasons to pick cereal over binary. The binary package now does the incremental data input stuff (and it's now faster than cereal). The binary package is the one on track to be added to the platform. If there's anything left, then we should just fix binary, the binary authors are keen.

Presumably as a workaround one can just make an orphan instance, since the EndPointAddress constructor is exposed.

@robstewart57
Copy link
Author

Thanks Duncan for addressing this ticket. In fact, HdpH adopted the cereal package, and hasn't been considered since that we move to binary. I'll just add an orphan instance for EndPointAddress for cereal within the HdpH codebase.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants