USPS: Remove trailing asterisks from rate names

hashrocketeer · Jan 10, 2011 · 85a51e5 · 85a51e5
1 parent cca7e73
commit 85a51e5
Show file tree

Hide file tree

Showing 4 changed files with 345 additions and 5 deletions.
diff --git a/lib/active_shipping/shipping/carriers/usps.rb b/lib/active_shipping/shipping/carriers/usps.rb
@@ -316,8 +316,8 @@ def rates_from_response_node(response_node, packages)
           package_node.each_element(service_node) do |service_response_node|
             service_name = service_response_node.get_text(service_name_node).to_s
 
-            # workaround for USPS messing up and including unescaped html in their rate names since Jan 2, 2011
-            service_name.gsub!(/&amp;lt;sup&amp;gt;&amp;amp;reg;&amp;lt;\/sup&amp;gt;/, '')
+            # workaround for USPS messing up and including unescaped html and asterisks in their rate names since Jan 2, 2011
+            service_name.gsub!(/&amp;lt;sup&amp;gt;&amp;amp;reg;&amp;lt;\/sup&amp;gt;|\*+$/, '')
 
             # aggregate specific package rates into a service-centric RateEstimate
             # first package with a given service name will initialize these;

diff --git a/...fixtures/xml/usps/2011_rates_response.xml → ...xml/usps/2011_domestic_rates_response.xml b/...fixtures/xml/usps/2011_rates_response.xml → ...xml/usps/2011_domestic_rates_response.xml