Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add updated screenshots to kv subkey docs #29067
Docs: Add updated screenshots to kv subkey docs #29067
Changes from 4 commits
1ad8fae9118d71ee7d4eea411babe6749a54e9b4b8ad71064c6e253a5dc9e376e5fedb5c6578f1f83c4b7fdf6313bf88e6File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to revert, but I removed "data" here because "metadata" and "data" are key words in kv v2 and get confused a lot. In this engine it seems helpful to remove
dataunless we're talking specifically about "secret data" or endpoints that include/data/.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on the source of the confusion? They may be keywords, but "data" is also an English word that accurately describes the stuff stored in the kv plugin. I'm not against changing things to clarify, but avoiding the word altogether doesn't feel like a reasonable long-term solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I don't mean we should remove the use of
dataall together, but I think in regards to kv v2 specifically we should be intentional how we use it. Since kv v2 plugins store "secret data" and "metadata," using "data" to encompass both can be confusing.Most of the time this distinction will probably just be important internally. However, in this context it sounds like users are navigating to
secret data, which is not true (anymore). Now the overview page exists as a intermediary layer and clicking a secret path from the list no longer directs users to the "data page."The overview was added as an additional layer of security so users with
readcapabilities to:engine/data/:secret_pathwouldn't inadvertently read sensitive secret values when clicking into a secret path. So while the overview technically contains data about the secret, the "data" distinction is important here so we're clear it's not secret data.Happy to discuss over zoom if that's easier 😄