Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce PKI issuer constraints #29045

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

victorr
Copy link
Contributor

@victorr victorr commented Nov 27, 2024

This PR re-implements #28921.

Description

Enforce PKI issuer constraints.

Add environment variable VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION.

Setting VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION=true will disable the cert issuance/signing verification.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@victorr victorr added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Nov 27, 2024
@victorr victorr added this to the 1.18.3 milestone Nov 27, 2024
@victorr victorr self-assigned this Nov 27, 2024
@victorr victorr requested review from a team as code owners November 27, 2024 16:49
@victorr victorr requested review from hashneo and removed request for a team November 27, 2024 16:49
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 27, 2024
Add environment variable VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION.

Setting VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION=true will disable the cert
issuance/signing verification.
@victorr victorr force-pushed the victorr/vault-22013-pki-verify-cert-take-two branch from ca4350b to 8920743 Compare November 27, 2024 16:50
Copy link

github-actions bot commented Nov 27, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Nov 27, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@kitography kitography left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these make sense - I do like the tests. The cert_verify has enough for backports, and the changelog and documentation are well written (still). 👍

@victorr victorr merged commit 48cec97 into main Nov 27, 2024
93 checks passed
@victorr victorr deleted the victorr/vault-22013-pki-verify-cert-take-two branch November 27, 2024 17:34
victorr added a commit that referenced this pull request Nov 27, 2024
Add environment variable VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION.

Setting VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION=true will disable the cert
issuance/signing verification.
victorr added a commit that referenced this pull request Nov 27, 2024
Add environment variable VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION.

Setting VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION=true will disable the cert
issuance/signing verification.

Co-authored-by: Victor Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants