-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce PKI issuer constraints #29045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorr
added
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
backport/1.18.x
backport/ent/1.17.x+ent
Changes are backported to 1.17.x+ent
labels
Nov 27, 2024
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Nov 27, 2024
Add environment variable VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION. Setting VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION=true will disable the cert issuance/signing verification.
victorr
force-pushed
the
victorr/vault-22013-pki-verify-cert-take-two
branch
from
November 27, 2024 16:50
ca4350b
to
8920743
Compare
CI Results: |
Build Results: |
6 tasks
kitography
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these make sense - I do like the tests. The cert_verify has enough for backports, and the changelog and documentation are well written (still). 👍
6 tasks
victorr
added a commit
that referenced
this pull request
Nov 27, 2024
Add environment variable VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION. Setting VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION=true will disable the cert issuance/signing verification.
victorr
added a commit
that referenced
this pull request
Nov 27, 2024
Add environment variable VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION. Setting VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION=true will disable the cert issuance/signing verification. Co-authored-by: Victor Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
backport/ent/1.17.x+ent
Changes are backported to 1.17.x+ent
backport/1.18.x
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-implements #28921.
Description
Enforce PKI issuer constraints.
Add environment variable VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION.
Setting VAULT_DISABLE_PKI_CONSTRAINTS_VERIFICATION=true will disable the cert issuance/signing verification.
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.