Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cached OCSP client support to Cert Auth #17093

Merged
merged 44 commits into from
Nov 21, 2022
Merged

Add cached OCSP client support to Cert Auth #17093

merged 44 commits into from
Nov 21, 2022

Commits on Sep 8, 2022

  1. wip

    @sgmiller
    sgmiller committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    8f34df9 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Add cached OCSP client support to Cert Auth

    @sgmiller
    sgmiller committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    5b63032 View commit details
    Browse the repository at this point in the history

  2. ->pointer

    @sgmiller
    sgmiller committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    b0798a7 View commit details
    Browse the repository at this point in the history

  3. Code cleanup

    @sgmiller
    sgmiller committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    87bd5a3 View commit details
    Browse the repository at this point in the history

  4. Fix unit tests

    @sgmiller
    sgmiller committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    0b9f785 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Use an LRU cache, and only persist up to 1000 of the most recently us… 

    …ed values to stay under the storage entry limit
    @sgmiller
    sgmiller committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    fb65fd5 View commit details
    Browse the repository at this point in the history

  2. Fix caching, add fail open mode parameter to cert auth roles

    @sgmiller
    sgmiller committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    5d768c0 View commit details
    Browse the repository at this point in the history

  3. reduce logging

    @sgmiller
    sgmiller committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    6e00633 View commit details
    Browse the repository at this point in the history

  4. Add the retry client and GET then POST logic

    @sgmiller
    sgmiller committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    44d808d View commit details
    Browse the repository at this point in the history

  5. Drop persisted cache, make cache size configurable, allow for paralle… 

    …l testing of multiple servers
    @sgmiller
    sgmiller committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    2b73de7 View commit details
    Browse the repository at this point in the history

  6. dead code

    @sgmiller
    sgmiller committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    0f9cda6 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Update builtin/credential/cert/path_certs.go 

    Co-authored-by: Alexander Scheel <[email protected]>
    @sgmiller @cipherboy
    sgmiller and cipherboy authored Sep 13, 2022
    Configuration menu
    Copy the full SHA
    fca24ee View commit details
    Browse the repository at this point in the history

  2. Hook invalidate to reinit the ocsp cache size

    @sgmiller
    sgmiller committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    59a3769 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'cert-auth-ocsp' of github.com:/hashicorp/vault into cer… 

    …t-auth-ocsp
    @sgmiller
    sgmiller committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    ae8423c View commit details
    Browse the repository at this point in the history

  4. locking

    @sgmiller
    sgmiller committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    ea1feb4 View commit details
    Browse the repository at this point in the history

  5. Conditionally init the ocsp client

    @sgmiller
    sgmiller committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    e7d790d View commit details
    Browse the repository at this point in the history

  6. Remove cache size config from cert configs, it's a backend global

    @sgmiller
    sgmiller committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    75244c9 View commit details
    Browse the repository at this point in the history

  7. Add field

    @sgmiller
    sgmiller committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    68c3308 View commit details
    Browse the repository at this point in the history

  8. Remove strangely complex validity logic

    @sgmiller
    sgmiller committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    acc2c29 View commit details
    Browse the repository at this point in the history

  9. Address more feedback

    @sgmiller
    sgmiller committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    81e8d6a View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Rework error returning logic

    @sgmiller
    sgmiller committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    ca7e8c0 View commit details
    Browse the repository at this point in the history

  2. More edge cases

    @sgmiller
    sgmiller committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    b5f2b03 View commit details
    Browse the repository at this point in the history

  3. MORE edge cases

    @sgmiller
    sgmiller committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    6ba87f9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into cert-auth-ocsp

    @sgmiller
    sgmiller committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    4abdc5a View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Merge remote-tracking branch 'origin/main' into cert-auth-ocsp

    @sgmiller
    sgmiller committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    1be9cf5 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Add a test matrix with a builtin responder

    @sgmiller
    sgmiller committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    51db45f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into cert-auth-ocsp

    @sgmiller
    sgmiller committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    8b39c75 View commit details
    Browse the repository at this point in the history

  3. changelog

    @sgmiller
    sgmiller committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    0642d7e View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Use an atomic for configUpdated

    @sgmiller
    sgmiller committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    0ff724c View commit details
    Browse the repository at this point in the history

  2. Actually use ocsp_enabled, and bind to a random port for testing

    @sgmiller
    sgmiller committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    7e50dd0 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Update builtin/credential/cert/path_login.go 

    Co-authored-by: Alexander Scheel <[email protected]>
    @sgmiller @cipherboy
    sgmiller and cipherboy authored Nov 7, 2022
    Configuration menu
    Copy the full SHA
    222bc58 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Refactor unit tests

    @sgmiller
    sgmiller committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    f192134 View commit details
    Browse the repository at this point in the history

  2. Add status to cache

    @sgmiller
    sgmiller committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    b8fb6ed View commit details
    Browse the repository at this point in the history

  3. Make some functions private

    @sgmiller
    sgmiller committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    9933c3b View commit details
    Browse the repository at this point in the history

  4. Rename for testing, and attribute

    @sgmiller
    sgmiller committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    6912f06 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into cert-auth-ocsp

    @sgmiller
    sgmiller committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    bf4e630 View commit details
    Browse the repository at this point in the history

  6. Up to date gofumpt

    @sgmiller
    sgmiller committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    4021908 View commit details
    Browse the repository at this point in the history

  7. remove hash from key, and disable the vault dependent unit test

    @sgmiller
    sgmiller committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    8143803 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Comment out TestMultiOCSP

    @sgmiller
    sgmiller committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    e91c2cf View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. imports

    @sgmiller
    sgmiller committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    ff60c7d View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. more imports

    @sgmiller
    sgmiller committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    65bb99a View commit details
    Browse the repository at this point in the history

  2. Address semgrep results

    @sgmiller
    sgmiller committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    9a2acb3 View commit details
    Browse the repository at this point in the history

  3. Attempt to pass some sort of logging to test_responder

    @sgmiller
    sgmiller committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    899f36d View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. fix overzealous search&replace

    @sgmiller
    sgmiller committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    ec3d5ff View commit details
    Browse the repository at this point in the history