WIF support for GCP auth engine #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
reviewed
May 8, 2024
fairclothjm
approved these changes
May 8, 2024
fairclothjm
reviewed
May 8, 2024
| var _ externalaccount.SubjectTokenSupplier = (*PluginIdentityTokenSupplier)(nil) | ||
|
|
||
| func (p *PluginIdentityTokenSupplier) SubjectToken(ctx context.Context, opts externalaccount.SupplierOptions) (string, error) { | ||
| p.logger.Info("fetching new plugin identity token") |
There was a problem hiding this comment.
nit: I would make this debug level or maybe even trace.
Zlaticanin
approved these changes
May 9, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds plugin WIF support to the GCP auth engine. This adds the following new fields to the config endpoint to enable configuring Workload Identity Federation:
identity_token_audienceidentity_token_ttlservice_account_emailThe PR adds the
PluginIdentityTokenSupplierCredential Provider that fetches a plugin identity token from Vault and passes it to an external account Token Source for a valid federated credential exchange. The PR also pulls in the latest tagv0.9.0for thego-gcp-commonlibrary with WIF utils.