Backport of [ui] Volumes and plugins navigation fixes, generally into release/1.9.x #24569
+27
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #24542 to be assessed for backporting due to the inclusion of the label backport/1.9.x.
The below text is copied from the body of the original PR.
Description
Mainly, this fixes a bug where navigating to a volume from the Storage page would error. This was happening because it was escaping the
/
after thecsi/
prefix that Ember Data uses to route things. I made a similar bugfix a few months ago for plugins, but didn't think to check volumes as wellAdditionally, found a few more quality-of-life around navigation within storage:
u
keyboard shortcut would pass more info than needed to get from/volumes/:id
back to/volumes
(this is because it's one level more nested than most breadcrumb up-a-level nav; /storage/plugins and /storage are the same page, as far as breadcrumbs are concerned)csi/
slash escaping bug was fixed; this was because the DOM event being passed to ourlazyClick
method (to simulate clicking on a row when you type in a keynav combo, in this case) was coming back null. There's now a defensive Elvis (?.
) to return a falsy value in lazyClick.Testing & Reproduction steps
Make some volumes/plugins and navigate around to your heart's content
Resolves #23831
Overview of commits