dynamic host volumes: test client RPC and plugins #24535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulducat
force-pushed
the
dhv-plugins-test
branch
2 times, most recently
from
5d87cf0
to
6006775
Compare
gulducat
force-pushed
the
dhv-plugins-test
branch
from
6006775
to
0907adc
Compare
tgross
approved these changes
Nov 22, 2024
| @@ -167,7 +171,7 @@ func (hv *HostVolume) Validate() error { | |||
| } | |||
| } | |||
|
|
|||
| return mErr.ErrorOrNil() | |||
| return helper.FlattenMultierror(mErr.ErrorOrNil()) | |||
|
|
||
| plug := &HostVolumePluginMkdir{ | ||
| ID: "test-mkdir-plugin", | ||
| TargetPath: tmp, |
There was a problem hiding this comment.
This makes me realize that calling this field "target path" is maybe a little misleading, as it's the parent of the eventual target path.
There was a problem hiding this comment.
yeah, aside from "target", even "path" is ambiguous: could signify either a file or a dir. I'll be in this vicinity again with fingerprinting, so I'll keep this in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding tests for #24497
also happened to notice we weren't validating that volume ID was uuid-shaped, so add that too.
main issue: #24479