dynamic host volumes: monitor readiness from CLI #24528
Merged
+209
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
commented
Nov 21, 2024
| @@ -94,7 +94,7 @@ case "$1" in | |||
| create_volume "$host_path" "$CAPACITY_MIN_BYTES" | |||
| # output what Nomad expects | |||
| bytes="$(stat --format='%s' "$host_path.ext4")" | |||
| printf '{"path": "%s", "bytes": %s}' "$host_path", "$bytes" | |||
| printf '{"path": "%s", "bytes": %s}' "$host_path" "$bytes" | |||
There was a problem hiding this comment.
Fixes a trailing , that was being left in the host path.
tgross
force-pushed
the
dhv-cli-monitoring
branch
from
21a304c
to
80c2abe
Compare
When creating a dynamic host volumes, set up an optional monitor that waits for the node to fingerprint the volume as healthy. Ref: #24479
tgross
force-pushed
the
dhv-cli-monitoring
branch
from
80c2abe
to
65829df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a dynamic host volumes, set up an optional monitor that waits for the node to fingerprint the volume as healthy.
Ref: #24479
Example of use: