-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for retrieving data from OCI registries #272
base: main
Are you sure you want to change the base?
Conversation
@developer-guy If you want you can continue working on the PR. So far it was mostly a PoC of how to include ORAS in go-getter with rather minimal tests. I am also waiting for feedback from some of the maintainers to see what they think of including this in go-getter. |
kindly ping 🙋🏻♂️ |
+1 for this to be addressed 🙏 |
kindly ping ☝️ |
Is anyone still planning to work on this? |
definitely me ! 🙈 |
@developer-guy then Cosign verification of modules pulled over OCI? |
of course we can add that verification logic into the pulling process |
@developer-guy I assume that we'd need frontend (e.g. Terraform) integration to make it useful as without configuring the verification we'd just be checking that someone (anyone) ran Cosign on the binary? |
We can add validation by checking the subject field that points out the person who created that signature if you want more granular control over the resource you pull by limiting people you can trust. |
@developer-guy I was questioning how the subject validation data would be passed in without frontend support? E.G. How would I validate a TF module from an OCI repo was signed by a specific party without Terraform providing the capability to pass the information through to this library? |
This would also unblock hashicorp/terraform#31463. |
Ok I am working on improving this PR, given that there are now also open questions in the Terraform community. I just updated it with later versions of the ORAS lib. I still have a few open questions:
cc: @picatz |
Fixes #271
Draft PR showcasing the OCI getter that is used in Conftest. Let me know if it would be something go-getter is interested in including upstream.
Several existing registries with OCI support can be detected and the URL will recieve the oci:// protocol. Alternatively, the oci:// protocol can be added to the URL for other (e.g. private) registries. The deis/ORAS library is used to fetch the OCI artifacts from the storage.