Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick #16789 - Implement hss functions #16803

Open
wants to merge 2 commits into
base: release/0.57
Choose a base branch
from

Conversation

lukelee-sl
Copy link
Member

Description:
Cherry pick of # 16789 which implements the signSchedule and authorizeSchedule functions for HSS.

@lukelee-sl lukelee-sl added this to the v0.57 milestone Nov 26, 2024
@lukelee-sl lukelee-sl self-assigned this Nov 26, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 92.47%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1b4339d) 97640 63764 65.31%
Head commit (0238c6d) 97723 (+83) 63846 (+82) 65.33% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16803) 93 86 92.47%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 82.79570% with 16 lines in your changes missing coverage. Please review.

Project coverage is 63.61%. Comparing base (1b4339d) to head (0238c6d).

Files with missing lines Patch % Lines
...racts/hss/signschedule/SignScheduleTranslator.java 77.77% 5 Missing and 7 partials ⚠️
...mcontracts/hss/DispatchForResponseCodeHssCall.java 92.00% 1 Missing and 1 partial ⚠️
...rvice/contract/impl/exec/TransactionProcessor.java 66.66% 0 Missing and 1 partial ⚠️
...mpl/exec/scope/HandleSystemContractOperations.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.57   #16803      +/-   ##
==================================================
+ Coverage           63.59%   63.61%   +0.02%     
- Complexity          20399    20420      +21     
==================================================
  Files                2547     2547              
  Lines               94875    94958      +83     
  Branches             9913     9925      +12     
==================================================
+ Hits                60335    60407      +72     
- Misses              30922    30923       +1     
- Partials             3618     3628      +10     
Files with missing lines Coverage Δ
...orkflows/handle/dispatch/ChildDispatchFactory.java 91.30% <100.00%> (+0.86%) ⬆️
...a/com/hedera/node/config/data/ContractsConfig.java 100.00% <ø> (ø)
...p/service/contract/impl/exec/gas/DispatchType.java 100.00% <100.00%> (ø)
...impl/exec/scope/QuerySystemContractOperations.java 100.00% <100.00%> (ø)
...ract/impl/exec/scope/SystemContractOperations.java 100.00% <ø> (ø)
...t/impl/exec/systemcontracts/HssSystemContract.java 66.66% <ø> (ø)
.../impl/exec/systemcontracts/hss/HssCallAttempt.java 65.21% <100.00%> (+5.21%) ⬆️
.../impl/exec/systemcontracts/hss/HssCallFactory.java 100.00% <100.00%> (ø)
.../contract/impl/state/DispatchingEvmFrameState.java 89.47% <ø> (ø)
...rvice/contract/impl/exec/TransactionProcessor.java 94.38% <66.66%> (+0.12%) ⬆️
... and 3 more

... and 2 files with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant