-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement hss sign schedule function #16789
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Luke Lee <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16789 +/- ##
=============================================
+ Coverage 63.53% 63.55% +0.02%
- Complexity 20370 20391 +21
=============================================
Files 2537 2537
Lines 94746 94829 +83
Branches 9902 9914 +12
=============================================
+ Hits 60198 60273 +75
+ Misses 30941 30940 -1
- Partials 3607 3616 +9
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, ty @lukelee-sl !
Left a few suggestions for improvement but all up to you
...-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/TransactionProcessor.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ContractsConfig.java
Show resolved
Hide resolved
.../app/service/contract/impl/exec/systemcontracts/hss/signschedule/SignScheduleTranslator.java
Show resolved
Hide resolved
.../app/service/contract/impl/exec/systemcontracts/hss/signschedule/SignScheduleTranslator.java
Show resolved
Hide resolved
Signed-off-by: Luke Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Implements the
signSchedule
proxy contract function and theauthorizeSchedule
function for the Schedule system contract.Related issue(s):
Fixes #16700
Notes for reviewer:
A future pr will add additional BDD and unit test.
Checklist